Add dest addr information to incoming UDPPacket objects #5704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[approve ci clang-analyzer] |
Member
Author
|
This is blocking merging QUIC branch, which will be a part of 9.0 release. Please review this as soon as possible.. |
Contributor
|
@scw00 Can you review please ? |
scw00
previously approved these changes
Jul 22, 2019
scw00
reviewed
Jul 22, 2019
iocore/net/UnixUDPNet.cc
Outdated
| if (opt.ip_family == AF_INET) { | ||
| int enable = 1; | ||
| #ifdef IP_PKTINFO | ||
| safe_setsockopt(fd, IPPROTO_IP, IP_PKTINFO, reinterpret_cast<char *>(&enable), sizeof(enable)); |
Member
There was a problem hiding this comment.
nikpick: should we continue when setsockopt failed ?
Member
Author
There was a problem hiding this comment.
Added error checks. It's complicated a bit, because it fails even if IP_PKTINFO is defined and try the other to support various platforms.
Contributor
|
Blocks #5457 |
maskit
force-pushed
the
udp_packet_dest_addr
branch
from
5630733 to
78ccaa3
Compare
maskit
force-pushed
the
udp_packet_dest_addr
branch
from
78ccaa3 to
cac7e6b
Compare
Member
Author
|
@scw00 I added error checks. Please take another look and approve again if it's ok with you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Destination addr is not stored into incoming UDP packets.
QUIC implementation needs to know the address for connection migration (a new connection may use different network route, IP address).
This is required for QUIC support.